[webkit-reviews] review granted: [Bug 24502] REGRESSION: Horizontal scrolling reversed for tilt/ball wheels : [Attachment 28485] patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 12 12:30:39 PDT 2009
Darin Fisher (:fishd, Google) <darin at chromium.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 24502: REGRESSION: Horizontal scrolling reversed for tilt/ball wheels
https://bugs.webkit.org/show_bug.cgi?id=24502
Attachment 28485: patch v1
https://bugs.webkit.org/attachment.cgi?id=28485&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: WebCore/platform/win/WheelEventWin.cpp
...
>+ if (isMouseHWheel)
>+ delta = -delta; // Windows is <-- -/+ -->, WebKit wants <-- +/- -->
nit: indentation is wrong
otherwise LGTM.
More information about the webkit-reviews
mailing list