[webkit-reviews] review denied: [Bug 24398] BackForwardList doesn't initialize m_client, which causes a crash : [Attachment 28418] Fixed ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 12 11:33:41 PDT 2009
Darin Fisher (:fishd, Google) <darin at chromium.org> has denied Marc-Antoine Ruel
<maruel at chromium.org>'s request for review:
Bug 24398: BackForwardList doesn't initialize m_client, which causes a crash
https://bugs.webkit.org/show_bug.cgi?id=24398
Attachment 28418: Fixed ChangeLog
https://bugs.webkit.org/attachment.cgi?id=28418&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: WebCore/history/BackForwardListChromium.cpp
...
>+ , m_client(NULL)
As mentioned, this should be 0 instead of NULL. Please post a revised patch,
and then LGTM.
More information about the webkit-reviews
mailing list