[webkit-reviews] review requested: [Bug 24523] Add test to check that an invalid second argument of window.postMessage is ignored : [Attachment 28534] Patch addressing Alexey's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 12 11:02:35 PDT 2009


Pam Greene <pam at chromium.org> has asked  for review:
Bug 24523: Add test to check that an invalid second argument of
window.postMessage is ignored
https://bugs.webkit.org/show_bug.cgi?id=24523

Attachment 28534: Patch addressing Alexey's comments
https://bugs.webkit.org/attachment.cgi?id=28534&action=review

------- Additional Comments from Pam Greene <pam at chromium.org>
(In reply to comment #2)
> Is this correct behavior, or an implementation quirk? I doubt that I fully
> investigated this case when writing the code - but HTML5 seems to imply that
an
> exception should be raised. What does Firefox do?

Firefox (Mac 3.0.7) raises an exception.  The HTML4 spec doesn't say what to
do. HTML5 does imply that an exception should be raised. I'd suggest adding
this test as it is for now, to catch unintentional changes, and updating it
when there's a deliberate switchover to HTML5 behavior.

> I don't think that using the test framework here helps much, as we don't have
a
> long series of tests, and this isn't a fast/js test. As mentioned in another
> bug, such usage of successfullyParsed won't work in most interesting cases.

Yes, notice that successfullyParsed is not used in the normal way here, just
inserted to make the output look like what people expect to see.

In any case, I've pulled out the test framework in this patch, since as you say
it's not adding much.


More information about the webkit-reviews mailing list