[webkit-reviews] review requested: [Bug 24496] ChromeClients don't get addMessageToConsole() called for non-string arguments : [Attachment 28502] Fix logging of non-string values, v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 11 16:37:46 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 24496: ChromeClients don't get addMessageToConsole() called for non-string
arguments
https://bugs.webkit.org/show_bug.cgi?id=24496

Attachment 28502: Fix logging of non-string values, v2
https://bugs.webkit.org/attachment.cgi?id=28502&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
 LayoutTests/ChangeLog				    |	10 ++++++++++
 .../fast/js/console-non-string-values-expected.txt |	 7 +++++++
 LayoutTests/fast/js/console-non-string-values.html |	18 ++++++++++++++++++
 WebCore/ChangeLog				    |	19 +++++++++++++++++++
 WebCore/bindings/js/ScriptValue.cpp		    |	 1 -
 WebCore/bindings/js/ScriptValue.h		    |	 3 +++
 WebCore/page/Console.cpp			    |	 9 +++++----
 7 files changed, 62 insertions(+), 5 deletions(-)


More information about the webkit-reviews mailing list