[webkit-reviews] review requested: [Bug 24524] Introduce ScriptFunctionCall and ScriptObject abstractions : [Attachment 28496] Introduce ScriptObject and ScriptFunctionCall abstractions, v1.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 11 15:30:06 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 24524: Introduce ScriptFunctionCall and ScriptObject abstractions
https://bugs.webkit.org/show_bug.cgi?id=24524

Attachment 28496: Introduce ScriptObject and ScriptFunctionCall abstractions,
v1.
https://bugs.webkit.org/attachment.cgi?id=28496&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
 WebCore/ChangeLog				 |   29 ++++++
 WebCore/GNUmakefile.am 			 |    5 +
 WebCore/WebCore.pro				 |    2 +
 WebCore/WebCore.vcproj/WebCore.vcproj		 |   20 ++++
 WebCore/WebCore.xcodeproj/project.pbxproj	 |   20 ++++
 WebCore/WebCoreSources.bkl			 |    2 +
 WebCore/bindings/js/ScriptFunctionCall.cpp	 |  122 +++++++++++++++++++++++
 WebCore/bindings/js/ScriptFunctionCall.h	 |   63 ++++++++++++
 WebCore/bindings/js/ScriptObject.cpp		 |   63 ++++++++++++
 WebCore/bindings/js/ScriptObject.h		 |   57 +++++++++++
 WebCore/bindings/js/ScriptObjectQuarantine.h	 |   62 ++++++++++++
 WebCore/inspector/InspectorController.cpp	 |   87 +---------------
 WebCore/inspector/InspectorController.h	 |    4 -
 WebCore/inspector/InspectorDatabaseResource.cpp |   53 +++++++---
 WebCore/inspector/InspectorDatabaseResource.h	 |   18 ++--
 15 files changed, 496 insertions(+), 111 deletions(-)


More information about the webkit-reviews mailing list