[webkit-reviews] review denied: [Bug 24368] DOM WheelEvent delta conversion inaccurate : [Attachment 28324] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 11 11:53:03 PDT 2009

Dave Hyatt <hyatt at apple.com> has denied Peter Kasting <pkasting at google.com>'s
request for review:
Bug 24368: DOM WheelEvent delta conversion inaccurate

Attachment 28324: patch v1

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I'd like to see a patch that does not force any platform but Windows to write
specific code.	Here would be my suggestions:

(1) Do the 120 multiplication in one place (probably in the DOM code).
(2) Instead of a "DOM" member in the wheel event, I'd have a wheel tick member
or something, e.g., something that just represents the # of lines.

More information about the webkit-reviews mailing list