[webkit-reviews] review requested: [Bug 24459] Add v8 bindings for event. : [Attachment 28453] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 10 15:40:43 PDT 2009


David Levin <levin at chromium.org> has asked  for review:
Bug 24459: Add v8 bindings for event.
https://bugs.webkit.org/show_bug.cgi?id=24459

Attachment 28453: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=28453&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I think I've addressed all style issues.

> The only concern is the use of empty V8 return value and figuring out what
that actually means. 
As we found out for these cases, it is how V8 returns 'null'.  Usually it means
not-found.


More information about the webkit-reviews mailing list