[webkit-reviews] review denied: [Bug 24456] Chromium Unforking: Split ColorChromium.cpp into Windows + Mac variants : [Attachment 28408] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 24456: Chromium Unforking: Split ColorChromium.cpp into Windows + Mac
variants
https://bugs.webkit.org/show_bug.cgi?id=24456

Attachment 28408: patch
https://bugs.webkit.org/attachment.cgi?id=28408&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why is it so important to remove the dependance on ColorMac.mm?  It seems that
it would be better for us to not duplicate code as a general rule.

Splitting out the win version seems fine, but it seems it also needs a comment
about Windows listening to the browser process for focus changes.  Probably the
"getting the focus ring color from the browser process" could be x-platform
code.