[webkit-reviews] review requested: [Bug 24001] [GTK] Cache control APIs : [Attachment 28394] Implement 3 cache models for gtk target

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 7 18:44:54 PST 2009


Bobby Powers <bobbypowers at gmail.com> has asked	for review:
Bug 24001: [GTK] Cache control APIs
https://bugs.webkit.org/show_bug.cgi?id=24001

Attachment 28394: Implement 3 cache models for gtk target
https://bugs.webkit.org/attachment.cgi?id=28394&action=review

------- Additional Comments from Bobby Powers <bobbypowers at gmail.com>
this adds a dependency to libgtop.  I couldn't find another way to find total
system memory in a platform-agnostic way.  libgtop releases seem synced to
GNOME, but its only linked against glib (doesn't pull in GNOME dependencies). 
If this is really a problem, I suppose I could go through and pull out the
platform dependent ways for mac, windows, {free|open}bsd, linux and create an
internal webkit function to find the total memory, but it seems like a big
hassle.

The cache model implementation is almost line for line the same as the Mac
implementation, except on the mac they also manipulate NSURLCache.  The GTK
equivalent would be libsoup, but I'm told libsoup doesn't do any caching yet.


More information about the webkit-reviews mailing list