[webkit-reviews] review granted: [Bug 24306] Add a way to figure-out if a ResourceRequest requires upload progress notifications : [Attachment 28370] New patch with ChangeLog fixed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 13:12:49 PST 2009


Darin Fisher (:fishd, Google) <darin at chromium.org> has granted Jay Campan
<jcampan at google.com>'s request for review:
Bug 24306: Add a way to figure-out if a ResourceRequest requires upload
progress notifications
https://bugs.webkit.org/show_bug.cgi?id=24306

Attachment 28370: New patch with ChangeLog fixed.
https://bugs.webkit.org/attachment.cgi?id=28370&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: WebCore/platform/network/ResourceRequestBase.h
...
>+	  void setReportUploadProgress(bool reportUploadProgress) {
m_reportUploadProgress = reportUploadProgress;	}

nit: extra whitespace before the "}"

otherwise LGTM


More information about the webkit-reviews mailing list