[webkit-reviews] review cancelled: [Bug 24260] Loading progress for blank views : [Attachment 28116] This corrects mime and navigation handling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 12:05:04 PST 2009


Christian Dywan <christian at twotoasts.de> has cancelled Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 24260: Loading progress for blank views
https://bugs.webkit.org/show_bug.cgi?id=24260

Attachment 28116: This corrects mime and navigation handling
https://bugs.webkit.org/attachment.cgi?id=28116&action=review

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
(In reply to comment #3)
> I think we should either use our webkit_web_policy_decision functions
> everywhere or not, but don't mix them with the low level C++ alternative.
Other
> than that looks great!

I agree mixing isn't good for readbility. I chose to use WebKitGTK+ API
everywhere now including existing calls, I think it's a little easier on the
eyes than the bracket-heavy WebCore version.


More information about the webkit-reviews mailing list