[webkit-reviews] review granted: [Bug 22790] [Transforms] MediaPlayer::setRect() makes no sense with transforms : [Attachment 28366] proposed patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
https://bugs.webkit.org/show_bug.cgi?id=22790

Attachment 28366: proposed patch
https://bugs.webkit.org/attachment.cgi?id=28366&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp
> ===================================================================

> -    //TODO: m_rect vs rect?
> +    //TODO: m_size vs rect?

Is the TODO still applicable?

> Index: WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h
> ===================================================================

> +    IntRect m_rect;

I have a minor preference for just storing a size in the member var,
and constructing a (0,0,size) rect where you need one.

> Index: WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm

> +    , m_rect(IntRect())

No need to initialize. IntRect has a ctor.

> +	if (m_player->inMediaDocument() && r != m_rect) {
> +			// the QTMovieView needs to be placed in the proper
location for document mode
> +		m_rect = r;
> +			[view setFrame:m_rect];

Tabs here?

r=me with those comments addressed.