[webkit-reviews] review granted: [Bug 24422] REGRESSION: null-URL crash in FrameLoader setting location.hash on new window : [Attachment 28359] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on
new window
https://bugs.webkit.org/show_bug.cgi?id=24422

Attachment 28359: patch
https://bugs.webkit.org/attachment.cgi?id=28359&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>+shouldBe("testWindow.location.toString()", "'/'"); // Firefox returns
about:blank
>+shouldBe("testWindow.location.href", "'/'"); // Firefox returns about:blank
>+shouldBe("testWindow.location.protocol", "':'"); // Firefox returns about:
>+shouldBe("testWindow.location.host", "''"); // Firefox throws an exception
>+shouldBe("testWindow.location.hostname", "''"); // Firefox throws an
exception

This patch looks good to me.  (I verified that all of the URL strings have
been completed before the isEmpty checks.)  However, I wonder about all of
these behavior differences from Firefox.  Are those potential compat issues?