[webkit-reviews] review granted: [Bug 24358] [GTK] Scrollbars not clipped correctly : [Attachment 28270] onlyrenderscrollbar.patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 24358: [GTK] Scrollbars not clipped correctly
https://bugs.webkit.org/show_bug.cgi?id=24358

Attachment 28270: onlyrenderscrollbar.patch
https://bugs.webkit.org/attachment.cgi?id=28270&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
> From a0e3df34a1bfd4fb3234e2459226cf485ce036f8 Mon Sep 17 00:00:00 2001
> From: Xan Lopez <xan at gnome.org>
> Date: Wed, 4 Mar 2009 20:23:06 +0200
> Subject: [PATCH 3/3] 2009-03-04  Xan Lopez  <xan at gnome.org>
> 
>	  Reviewed by NOBODY (OOPS!).
> 
>	  https://bugs.webkit.org/show_bug.cgi?id=24358
>	  [GTK] Scrollbars not clipped correctly
> 
>	  Do not take into account the case of being a ScrollView scrollbar,
>	  since those are native in our case.
> 
>	  * platform/gtk/ScrollbarGtk.cpp:
>	  (ScrollbarGtk::frameRectsChanged):
> ---
>  WebCore/ChangeLog			 |   17 +++++++++++++++--
>  WebCore/platform/gtk/ScrollbarGtk.cpp |   16 +++-------------
>  2 files changed, 18 insertions(+), 15 deletions(-)
> 
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index c6352e7..cd3f559 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -5,8 +5,21 @@
>	   https://bugs.webkit.org/show_bug.cgi?id=24358
>	   [GTK] Scrollbars not clipped correctly
>  
> -	Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
> -	specific and it's our only Widget anyway.
> +	   Do not take into account the case of being a ScrollView scrollbar,
> +	   since those are native in our case.

^^^ oh, tabs vs. space?

for the rest, let us try it :)



>