[webkit-reviews] review granted: [Bug 24358] [GTK] Scrollbars not clipped correctly : [Attachment 28269] movepaint.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 07:59:54 PST 2009


Holger Freyther <zecke at selfish.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 24358: [GTK] Scrollbars not clipped correctly
https://bugs.webkit.org/show_bug.cgi?id=24358

Attachment 28269: movepaint.patch
https://bugs.webkit.org/attachment.cgi?id=28269&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +/*
> + * Strategy to painting a Widget:
> + *  1.) do not paint if there is no GtkWidget set
> + *  2.) We assume that GTK_NO_WINDOW is set and that frameRectsChanged
positioned
> + *	   the widget correctly. ATM we do not honor the GraphicsContext
translation.

okay, if you update the comment in the previous patch then update this as
well..


More information about the webkit-reviews mailing list