[webkit-reviews] review granted: [Bug 24358] [GTK] Scrollbars not clipped correctly : [Attachment 28268] cliprect.patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 24358: [GTK] Scrollbars not clipped correctly
https://bugs.webkit.org/show_bug.cgi?id=24358

Attachment 28268: cliprect.patch
https://bugs.webkit.org/attachment.cgi?id=28268&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> --- a/WebCore/platform/gtk/WidgetGtk.cpp
> +++ b/WebCore/platform/gtk/WidgetGtk.cpp
> @@ -101,7 +101,7 @@ void Widget::hide()
>   *  2.) We assume that GTK_NO_WINDOW is set and that frameRectsChanged
positioned
>   *	   the widget correctly. ATM we do not honor the GraphicsContext
translation.

maybe we can update the comment? I think this was meant with GraphicsContext...



>   */
> -void Widget::paint(GraphicsContext* context, const IntRect&)
> +void Widget::paint(GraphicsContext* context, const IntRect& rect)
>  {
>      if (!platformWidget())
>	   return;
> @@ -114,7 +114,13 @@ void Widget::paint(GraphicsContext* context, const
IntRect&)
>  
>      GdkEvent* event = gdk_event_new(GDK_EXPOSE);
>      event->expose = *context->gdkExposeEvent();
> -    event->expose.region = gtk_widget_region_intersect(widget,
event->expose.region);
> +    event->expose.area = static_cast<GdkRectangle>(rect);

this is using the operator GtkRectangle()...