[webkit-reviews] review requested: [Bug 16482] Hook up ICU's encoding detector and add a boolean param to Settings and WebPreferences : [Attachment 28353] updated patch with ap's review comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 01:25:00 PST 2009


Jungshik Shin <jshin at chromium.org> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 16482: Hook up ICU's encoding detector and add a boolean param to Settings
and WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=16482

Attachment 28353: updated patch with ap's review comments addressed
https://bugs.webkit.org/attachment.cgi?id=28353&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Thank you for the review. Can you take another look? 

* Added/fixed copyright/license in newly added files (I copied it from other
chrome-contributed files)
* Fixed style nits (NULL, indentation, tab, etc)
* Added more comments to clarify what it does in ChangeLog and source files.


More information about the webkit-reviews mailing list