[webkit-reviews] review requested: [Bug 24342] Cannot insert a Thai character after a Thai prepend character when using ICU 4.0 : [Attachment 28346] a proposed fix 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 5 20:43:46 PST 2009


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 24342: Cannot insert a Thai character after a Thai prepend character when
using ICU 4.0
https://bugs.webkit.org/show_bug.cgi?id=24342

Attachment 28346: a proposed fix 3
https://bugs.webkit.org/attachment.cgi?id=28346&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Thank you for your useful comments and sorry for my slow updates.
I renamed inputCursorIterator to cursorMovementIterator, and AtomicString to
String. Also I removed a redundant "!!chain;" rule and updated comments.
(As for Issue 15790, I'm also checking it with my local build of Chrome. I'm
going to update the issue when I find something.)
Would it be possible to review it again?


More information about the webkit-reviews mailing list