[webkit-reviews] review denied: [Bug 23024] Crash beneath addOverhangingFloats() at trazi.appspot.com : [Attachment 28336] small bug fix and test

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 23024: Crash beneath addOverhangingFloats() at trazi.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=23024

Attachment 28336: small bug fix and test
https://bugs.webkit.org/attachment.cgi?id=28336&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I'm concerned about the performance implications of simply removing this check,
especially in the case where no floatToRemove is passed in.  I'm not convinced
the check is wrong in the case where no floatToRemove is passed in, since in
that case the function is being called from places like block layout, where
float/position status hasn't been changing.

Also your layout test seems dependent on a timeout without waiting until done,
so you need to fix the test to only move on after the timeout has happened.