[webkit-reviews] review requested: [Bug 24079] REGRESSION(r39549): Page loads cannot be interrupted with Command-. or Escape : [Attachment 28339] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 5 17:07:31 PST 2009


Adele Peterson <adele at apple.com> has asked  for review:
Bug 24079: REGRESSION(r39549): Page loads cannot be interrupted with Command-.
or Escape
https://bugs.webkit.org/show_bug.cgi?id=24079

Attachment 28339: patch
https://bugs.webkit.org/attachment.cgi?id=28339&action=review

------- Additional Comments from Adele Peterson <adele at apple.com>
I tested this by making sure cmd-. and escape cause loading to be stopped.  I
tested that ctrl-tab works to switch tabs when focus is in a text field.  And I
tested that pageup/pagedown and home/end work with Mail.  And I ran layout
tests.

I'm not convinced this solution is perfect, but I am sure it works better than
our current code for many cases.


More information about the webkit-reviews mailing list