[webkit-reviews] review denied: [Bug 24324] Make DOMTimer clamp adjustable via settings : [Attachment 28225] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 5 14:08:11 PST 2009

Dave Hyatt <hyatt at apple.com> has denied Mike Belshe <mike at belshe.com>'s request
for review:
Bug 24324: Make DOMTimer clamp adjustable via settings

Attachment 28225: patch

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I think you need a comment explaining why a #define is being used.  It's ok to
mention that Chromium has no clamp in the comment.  We need to make sure people
know why this oddity is here, since otherwise they might just yank the code.

Also need a ChangeLog comment.

More information about the webkit-reviews mailing list