[webkit-reviews] review granted: [Bug 17284] [CAIRO] Introduce single-pixel image optimizations : [Attachment 28302] single pixel optimization with Color

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 5 12:25:57 PST 2009


Eric Seidel <eric at webkit.org> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 17284: [CAIRO] Introduce single-pixel image optimizations
https://bugs.webkit.org/show_bug.cgi?id=17284

Attachment 28302: single pixel optimization with Color
https://bugs.webkit.org/attachment.cgi?id=28302&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
halves, not halfes

 148 Color colorFromPremultipliedARGB(RGBA32);

should use unsigned, not RGBA32

This looks good.  It would be nice if someone could check your pixel math
before you land.  Like Oliver?


More information about the webkit-reviews mailing list