[webkit-reviews] review cancelled: [Bug 24342] Cannot insert a Thai character after a Thai prepend character when using ICU 4.0 : [Attachment 28262] A proposed fix 2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has cancelled Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 24342: Cannot insert a Thai character after a Thai prepend character when
using ICU 4.0
https://bugs.webkit.org/show_bug.cgi?id=24342

Attachment 28262: A proposed fix 2
https://bugs.webkit.org/attachment.cgi?id=28262&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I've now built a local copy of ICU 4.0.1, and I can reproduce this problem in
Safari with it. I think that the approach in this fix is absolutely correct.

Instead of inputCursorIterator, I'd say "cursorMovementIterator" - it is not
directly related to input, as it will be used for e.g. selecting non-editable
text.

Looking over other uses of characterBreakIterator in WebCore, I noticed another
case that might be incorrect, which is in
CoreTextController::offsetForPosition(). It's better to handle it separately
though.

Clearing review flag for now, as you said that you were going to submit a new
patch.