[webkit-reviews] review granted: [Bug 24377] [GTK] Comply better with coding style guidelines in ResourceHandleSoup : [Attachment 28298] resourcehandlesoupstyle.patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 5 04:13:45 PST 2009
Mark Rowe (bdash) <mrowe at apple.com> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 24377: [GTK] Comply better with coding style guidelines in
ResourceHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=24377
Attachment 28298: resourcehandlesoupstyle.patch
https://bugs.webkit.org/attachment.cgi?id=28298&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
r=me. I mentioned a few other points on IRC that would be good to address:
m_input_stream and m_bufsize don't match our style guidelines, and there are
variables in readCallback and openCallback that are declared several lines
before they're first used.
More information about the webkit-reviews
mailing list