[webkit-reviews] review denied: [Bug 24327] Fix hit testing on elements running accelerated transform animations : [Attachment 28287] Patch, changelog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 4 17:27:41 PST 2009
Eric Seidel <eric at webkit.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 24327: Fix hit testing on elements running accelerated transform animations
https://bugs.webkit.org/show_bug.cgi?id=24327
Attachment 28287: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=28287&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Since you never seem to use the "has a transform" bool return, why not just
have it return a TransformationMatrix object instead of passing one by
reference? Seems cleaner to return one to me.
Otherwise looks fine. You should add a comment to the ChangeLog that the test
case in question only fails when ACCELLERATED_COMPOSITING is turned on.
More information about the webkit-reviews
mailing list