[webkit-reviews] review granted: [Bug 24369] Chromium Linux: change some metrics to better match Windows : [Attachment 28286] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 4 16:11:37 PST 2009
Darin Fisher (:fishd, Google) <darin at chromium.org> has granted Adam Langley
<agl at chromium.org>'s request for review:
Bug 24369: Chromium Linux: change some metrics to better match Windows
https://bugs.webkit.org/show_bug.cgi?id=24369
Attachment 28286: patch
https://bugs.webkit.org/attachment.cgi?id=28286&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>+ Chromium Linux: change some metrics to better match Windows after
>+ r41416. Aesthetically this may be worse, but web-compat is king.
it is good practice to list some of the tests corresponding to this change.
it sounds like you are making some tests pass now with this change, so those
would be good tests to list here. i think the syntax goes something like:
Test: fast/dom/fooBar.html
otherwise, LGTM
More information about the webkit-reviews
mailing list