[webkit-reviews] review requested: [Bug 23482] Replaces Yin-Yang character with a thumb-nail image in two layout tests : [Attachment 28288] patch with in-place modifications of css2.1 tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 4 15:40:48 PST 2009


Jungshik Shin <jshin at chromium.org> has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 23482: Replaces Yin-Yang character with a thumb-nail image in two layout
tests
https://bugs.webkit.org/show_bug.cgi?id=23482

Attachment 28288: patch with in-place modifications of css2.1 tests
https://bugs.webkit.org/attachment.cgi?id=28288&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Instead of duping css2.1 tests to a new place and revising them there, this
patch modifies the original tests in place.  It also removes the previously
added tests in fast/block/float. 

Somehow, png files added in attachment 27078 that are removed in this patch are
not recognized as binary and diff are not base64-encoded in the patch. (new png
files in css2.1/supports are recognized as image/png and base64-encoded).
However, running 'svn-unapply' and 'svn-apply' multiple times work. Also after
each 'svn-apply', webkit test passes.


More information about the webkit-reviews mailing list