[webkit-reviews] review granted: [Bug 24340] Expose allowUniversalAccessFromFileUrls to Qt : [Attachment 28252] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 4 00:29:39 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 24340: Expose allowUniversalAccessFromFileUrls to Qt
https://bugs.webkit.org/show_bug.cgi?id=24340

Attachment 28252: patch
https://bugs.webkit.org/attachment.cgi?id=28252&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	 Reviewed by NOBODY (OOPS!).
+
+	 Expose AllowUniversalAccessFromFileUrls to QT clients.

Please add a bug URL.

r=me, but AllowUniversalAccessFromFileUrls should really be
AllowUniversalAccessFromFileURLs - not just in Qt, but everywhere. It's
particularly unfortunate to have this exposed as a (private) preference, could
you please rename all instances? A separate patch would probably be more
appropriate.


More information about the webkit-reviews mailing list