[webkit-reviews] review granted: [Bug 24339] Add test for potential crash in window.frames.length : [Attachment 28250] New test + result

Tue Mar 3 23:28:41 PST 2009

Darin Fisher (:fishd, Google) <darin at chromium.org> has granted Pam Greene
<pam at chromium.org>'s request for review:
Bug 24339: Add test for potential crash in window.frames.length
https://bugs.webkit.org/show_bug.cgi?id=24339

Attachment 28250: New test + result
https://bugs.webkit.org/attachment.cgi?id=28250&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: fast/dom/window-collection-length-no-crash.html
>===================================================================
>--- fast/dom/window-collection-length-no-crash.html	(revision 0)
>+++ fast/dom/window-collection-length-no-crash.html	(revision 0)
>@@ -0,0 +1,22 @@
>+<HTML>
>+<script>
>+if (window.layoutTestController) {
>+  window.layoutTestController.dumpAsText();
>+  window.layoutTestController.waitUntilDone();
>+}
>+
>+function run_test() {

nit: run_test -> runTest


otherwise, LGTM