[webkit-reviews] review granted: [Bug 24201] WebCore::RenderBlock::layout taking superquadratic time : [Attachment 28244] Patch to fix bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 3 21:19:42 PST 2009
mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 24201: WebCore::RenderBlock::layout taking superquadratic time
https://bugs.webkit.org/show_bug.cgi?id=24201
Attachment 28244: Patch to fix bug
https://bugs.webkit.org/attachment.cgi?id=28244&action=review
------- Additional Comments from mitz at webkit.org
Wow. You're leaving me no choice but to pick nits:
> + if (child->shrinkToAvoidFloats())
> + // The child's width depends on the line width.
> + // When the child shifts to clear an item, its width can
> + // change (because it has more available line width).
> + // So go ahead and mark the item as dirty.
> + child->setChildNeedsLayout(true, false);
Need braces around this multi-line if block.
> + Test case for https://bugs.webkit.org/attachment.cgi?id=28239
Should link to the bug, not to the attachment.
r=me!
More information about the webkit-reviews
mailing list