[webkit-reviews] review granted: [Bug 24329] REGRESSION: console.dirxml() Console API broken : [Attachment 28231] Proposed Patch

[bugzilla-daemon at webkit.org]

Kevin McCullough <kmccullough at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 24329: REGRESSION: console.dirxml() Console API broken
https://bugs.webkit.org/show_bug.cgi?id=24329

Attachment 28231: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=28231&action=review

------- Additional Comments from Kevin McCullough <kmccullough at apple.com>

> diff --git a/WebCore/page/Console.cpp b/WebCore/page/Console.cpp
> index 8755f0e..697baac 100644
> --- a/WebCore/page/Console.cpp
> +++ b/WebCore/page/Console.cpp
> @@ -109,12 +109,13 @@ static void
printMessageSourceAndLevelPrefix(MessageSource source, MessageLevel
>  
>      const char* levelString;
>      switch (level) {
> +	   default:
> +	       ASSERT_NOT_REACHED();
> +	       levelString = "UNKNOWN";
> +	       break;

We usually put the default: at the end of the switch statement

It would be nice if the refactoring was in a separate patch but I don't have
many comments and it's good that there is a test case.