[webkit-reviews] review granted: [Bug 24331] Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame : [Attachment 28230] Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame, v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 3 11:11:49 PST 2009


Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 24331: Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame
https://bugs.webkit.org/show_bug.cgi?id=24331

Attachment 28230: Add custom V8 bindings for Element, Attr, HTMLFrame, and
HTMLIFrame, v1
https://bugs.webkit.org/attachment.cgi?id=28230&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.

I would have put toEventType closer to where it's used in the file.  I don't
think we have any rule about statics being at the top or anything (maybe we
should?)


More information about the webkit-reviews mailing list