[webkit-reviews] review requested: [Bug 17284] [CAIRO] Introduce single-pixel image optimizations : [Attachment 28221] single pixel optimization with CairoColor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 3 08:30:23 PST 2009

Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 17284: [CAIRO] Introduce single-pixel image optimizations

Attachment 28221: single pixel optimization with CairoColor

------- Additional Comments from Dirk Schulze <krit at webkit.org>
I talked to eseidel in IRC and he mentioned to add a new typedef or somthing
like that to avoid failured and make the code reading better.
I added a new color schema to Cairo: CairoColor. CairoColor attends to
premultiplying and every other calculation. I added some small callers to have
access to the color values of a pixel. You can easily get the unpremutiplied
colors of a pixel or set them by adding unpremultiplied colors.
We just support image surfaces with 32bit for now. There are asserts before
every direct manipulation of surfaces. But I don't see a problem to support
other surfaces in the future if wanted.

More information about the webkit-reviews mailing list