[webkit-reviews] review granted: [Bug 18983] Exception messages in console not always obvious : [Attachment 28184] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 18983: Exception messages in console not always obvious
https://bugs.webkit.org/show_bug.cgi?id=18983

Attachment 28184: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=28184&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>	  (WebInspector.Console.prototype._formaterror): Add an error-message
>	  classed span around the message to show in red and remove the
>	  console-message-url class from the link so it doesn't float right.
>	  Instead inclose the link in parenthesis and use displayNameForURL

Typos: inclose -> enclose, parenthesis -> parentheses

>	  (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
>	  how line numbers are shown since link underlining a string with
>	  parenthesis looks bad.

Typo: parenthesis -> parentheses

Can you make a manual test?

r=me