[webkit-reviews] review requested: [Bug 16826] [Gtk] Implement WebKitDownload : [Attachment 28191] proposed implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 2 11:59:44 PST 2009
Gustavo Noronha (kov) <gns at gnome.org> has asked for review:
Bug 16826: [Gtk] Implement WebKitDownload
https://bugs.webkit.org/show_bug.cgi?id=16826
Attachment 28191: proposed implementation
https://bugs.webkit.org/attachment.cgi?id=28191&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
[I am resending the patch because there were some errors in the automatic
merging git did to the main changelog, and I took the opportunity to remove a
rogue modification that escaped my eye; sorry for the mess]
This work has been reviewed by almost all major WebKitGTK+ contributors, and we
have a consensus on how the API should look like. This version of the patch
fixes some issues raised on IRC (removes the unnecessary download_requested
virtual class member in WebKitWebView, mainly) and contains some minor style
convention corrections.
More information about the webkit-reviews
mailing list