[webkit-reviews] review granted: [Bug 24244] Chromium Linux: switch to using Skia for widget renderer : [Attachment 28188] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has granted Adam Langley
<agl at chromium.org>'s request for review:
Bug 24244: Chromium Linux: switch to using Skia for widget renderer
https://bugs.webkit.org/show_bug.cgi?id=24244

Attachment 28188: patch
https://bugs.webkit.org/attachment.cgi?id=28188&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>+++ b/WebCore/platform/chromium/ScrollbarThemeChromium.cpp
...
>+    const int girth = 0;
>+    // On Linux, we don't use buttons
>+    return IntSize(0, 0);

seems like it shouldn't be necessary to define girth given the early return,
or does GCC complain without it being there?


>+++ b/WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp

>+    paint.setARGB(255, 0xe3, 0xdd, 0xd8);
...
>+    paint.setARGB(255, 0xc5, 0xba, 0xb0);

the mixing of decimal and hex really seems odd to me...  is that somehow
conventional?  (this hurts my brain)


>+++ b/WebCore/rendering/RenderThemeChromiumLinux.cpp

>+	  paint.setARGB(255, 0xe9, 0xe9, 0xe9);

ditto (and elsewhere in this file)