[webkit-reviews] review granted: [Bug 24275] Broken line edit theming in QtWebKit : [Attachment 28147] Patch which seems to fix the styling issues
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 2 10:04:55 PST 2009
Tor Arne Vestbø <tavestbo at trolltech.com> has granted Zack Rusin
<zack at kde.org>'s request for review:
Bug 24275: Broken line edit theming in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=24275
Attachment 28147: Patch which seems to fix the styling issues
https://bugs.webkit.org/attachment.cgi?id=28147&action=review
------- Additional Comments from Tor Arne Vestbø <tavestbo at trolltech.com>
Looks good, we do the same trick for buttons (adjusting padding).
One small nitpick:
> + //this will need ot be regenerated when the style changes
Also missing Changelog. No need to resubmit patch though, just fix and re=me.
Tor Arne
More information about the webkit-reviews
mailing list