[webkit-reviews] review denied: [Bug 3547] XMLHttpRequest.statusText returns always "OK" : [Attachment 28177] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 2 08:03:59 PST 2009

Alexey Proskuryakov <ap at webkit.org> has denied Adam Bergkvist
<adam.bergkvist at ericsson.com>'s request for review:
Bug 3547: XMLHttpRequest.statusText returns always "OK"

Attachment 28177: patch

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This is a good test, but it is not needed. There are at least two existing
tests that should change from FAIL to PASS with this test
(http/tests/xmlhttprequest/web-apps/012.html and 013.html). Instead of adding a
new test, please add platform-specific results for these ones, and please do
run all http tests. I believe that these tests should pass at least on gtk and
windows (CF) now - it may make sense to change default results to expected
ones, and to add platform-specific ones for platforms that don't pass yet.

It seems that QNetworkReplyHandler needs to set a fake httpStatusText, too.

More information about the webkit-reviews mailing list