[webkit-reviews] review granted: [Bug 24259] [Gtk] get the HTTP layout tests going : [Attachment 28132] DRT - support for dumping the back/forward history items and navigation and back/forward fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 1 08:26:54 PST 2009


Holger Freyther <zecke at selfish.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 24259: [Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Attachment 28132: DRT - support for dumping the back/forward history items and
navigation and back/forward fixes
https://bugs.webkit.org/attachment.cgi?id=28132&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +static WebKitWebHistoryItem* prevTestBFItem = NULL; // current b/f item at
the end of the previous test

please move the comment to the above line.



> +static void dumpHistoryItem(WebKitWebHistoryItem* item, int indent, bool
current)
> +{
> +    assert(item != NULL);

ASSERT(item); to use WTF




> +static void dumpBackForwardListForWebView(WebKitWebView* view)
> +{
> +    printf("\n============== Back Forward List ==============\n");
> +    WebKitWebBackForwardList* bfList =
webkit_web_view_get_back_forward_list(view);
> +
> +    // Print out all items in the list after prevTestBFItem, which was from
the previous test
> +    // Gather items from the end of the list, the print them out from oldest
to newest
> +    GList* itemsToPrint = NULL;
> +    gint forwardListCount =
webkit_web_back_forward_list_get_forward_length(bfList);
> +    for (int i = forwardListCount; i > 0; i--) {
> +	   WebKitWebHistoryItem* item =
webkit_web_back_forward_list_get_nth_item(bfList, i);
> +	   // something is wrong if the item from the last test is in the
forward part of the b/f list
> +	   assert(item != prevTestBFItem);

ASSERT?



please coordinate with kov/xan for the release.


More information about the webkit-reviews mailing list