[webkit-reviews] review granted: [Bug 26877] [GTK] DRT fixes to pass new plugin test : [Attachment 32115] compilerwarning.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 30 23:43:10 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 26877: [GTK] DRT fixes to pass new plugin test
https://bugs.webkit.org/show_bug.cgi?id=26877

Attachment 32115: compilerwarning.patch
https://bugs.webkit.org/attachment.cgi?id=32115&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
>      switch (variable) {
>	   case NPPVpluginNameString:
> -	       *((char **)value) = "WebKit Test PlugIn";
> +	       *((char **)value) = (char*)"WebKit Test PlugIn";

Please change these to static_casts before commit. r=me.


More information about the webkit-reviews mailing list