[webkit-reviews] review cancelled: [Bug 26827] Improve InlineBox::first/lastLeafChild methods : [Attachment 32031] patch fixing the issues in the bug description

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 30 18:30:49 PDT 2009


Roland Steiner <rolandsteiner at google.com> has cancelled Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26827: Improve InlineBox::first/lastLeafChild methods
https://bugs.webkit.org/show_bug.cgi?id=26827

Attachment 32031: patch fixing the issues in the bug description
https://bugs.webkit.org/attachment.cgi?id=32031&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Currently, the methods in question are called on RootInlineBox objects only,
AFAICT, so there should not be any observable effects (the mentioned behavior
can only happen if called on InlineFlowBox objects, basically).

Only the removal of the square runtime behavior when the remaining nodes in a
tree are all empty InlineFlowBox objects could be effective, but the conditions
for that are more theoretical in nature (i.e., would probably require to have a
pathological case to have any measurable impact).

Updated the ChangeLog accordingly.


More information about the webkit-reviews mailing list