[webkit-reviews] review granted: [Bug 26858] Add column reflection of dcol elements into datagrid's columns list. : [Attachment 32092] Patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 26858: Add column reflection of dcol elements into datagrid's columns list.
https://bugs.webkit.org/show_bug.cgi?id=26858

Attachment 32092: Patch
https://bugs.webkit.org/attachment.cgi?id=32092&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
id HTMLDataGridColElement::removedFromTree(bool deep)
> +{
> +    HTMLElement::removedFromTree(deep);
> +    if (datagrid() && datagrid()->dataSource()->isDOMDataGridDataSource()) {

> +	   HTMLDataGridElement* grid = findDatagridAncestor();
> +	   if (!grid && column()) {
> +	       datagrid()->columns()->remove(column());
> +	       m_datagrid = 0;
> +	   }
> +    }
> +}


I find this a little confusing. What is the difference between datagrid() and
the result of findDatagridAncestor().I would expect them to be the same.

r=me!