[webkit-reviews] review denied: [Bug 26791] [Gtk] Paste of rich text from firefox results garbled markup : [Attachment 32072] Fix the length size of GtkSelectionData from Pidgin and FireFox
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 30 10:59:59 PDT 2009
Eric Seidel <eric at webkit.org> has denied Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 26791: [Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791
Attachment 32072: Fix the length size of GtkSelectionData from Pidgin and
FireFox
https://bugs.webkit.org/attachment.cgi?id=32072&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
It seems like this would do a better job:
TextEncoding clipboardEncoding;
if (detectTextEncoding(data->data, data->len, "utf8", &clipboardEncoding))
html = clipboardEncoding.decode(data->data, data->len);
This also needs a manual test in WebCore/manual-tests/gtk
More information about the webkit-reviews
mailing list