[webkit-reviews] review granted: [Bug 26820] Fix an inverted null check in V8Proxy : [Attachment 32027] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 30 09:21:51 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted 's request for
review:
Bug 26820: Fix an inverted null check in V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=26820

Attachment 32027: patch
https://bugs.webkit.org/attachment.cgi?id=32027&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
This was a mis-type that occurred during upstreaming. It was discovered as a
failure of an existing test, but the test hasn't yet been upstreamed:

http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/chrome
/fast/dom/messageport-gc.html?revision=5770&view=markup

The test needs some cleaning up before upstreaming and I am hesitant to hold up
this fix for that.


More information about the webkit-reviews mailing list