[webkit-reviews] review requested: [Bug 26799] [Qt] Add QWebFrame::completeUrl() : [Attachment 32064] patch r2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 30 06:44:26 PDT 2009


Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 26799: [Qt] Add QWebFrame::completeUrl()
https://bugs.webkit.org/show_bug.cgi?id=26799

Attachment 32064: patch r2
https://bugs.webkit.org/attachment.cgi?id=32064&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
Yeah, that would make sense actually. Seems like it would be better to let user
use QUrl's functionality rather than have another function that completes
relative URLs (and I wonder if there are any edge cases where these two
functions would behave differently).

So here is a revised patch.


More information about the webkit-reviews mailing list