[webkit-reviews] review granted: [Bug 26835] [GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation() : [Attachment 32050] Use new api for gtk+2 >= 2.15.0, old otherwise

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 30 04:51:25 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted Adrien Nader
<camaradetux at gmail.com>'s request for review:
Bug 26835: [GTK] GtkLauncher depends on gtk+2-2.15 because of
gtk_orientable_set_orientation()
https://bugs.webkit.org/show_bug.cgi?id=26835

Attachment 32050: Use new api for gtk+2 >= 2.15.0, old otherwise
https://bugs.webkit.org/attachment.cgi?id=32050&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +#if GTK_CHECK_VERSION(2,15,0)
>      gtk_orientable_set_orientation (GTK_ORIENTABLE (toolbar),
GTK_ORIENTATION_HORIZONTAL);
> +#else
> +    gtk_toolbar_set_orientation(GTK_TOOLBAR(toolbar),
GTK_ORIENTATION_HORIZONTAL);
> +#endif

The spacing should be fixed before landing. r=me.


More information about the webkit-reviews mailing list