[webkit-reviews] review requested: [Bug 26835] [GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation() : [Attachment 32048] Patch to revert to "previous" (pre 2.15) api call

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 30 04:07:10 PDT 2009


Adrien Nader <camaradetux at gmail.com> has asked	for review:
Bug 26835: [GTK] GtkLauncher depends on gtk+2-2.15 because of
gtk_orientable_set_orientation()
https://bugs.webkit.org/show_bug.cgi?id=26835

Attachment 32048: Patch to revert to "previous" (pre 2.15) api call
https://bugs.webkit.org/attachment.cgi?id=32048&action=review

------- Additional Comments from Adrien Nader <camaradetux at gmail.com>
The patch partially reverts the patch from 26583 (landed in r45319) which
removed api calls which will be deprecated in gtk+3.
Wrapping that in #ifdef...#else...#endif looks like a nice solution (I'd done
it if I had known what to check for).


More information about the webkit-reviews mailing list