[webkit-reviews] review denied: [Bug 26590] Support for String.trim(), String.trimLeft() and String.trimRight() methods : [Attachment 31774] String.trim(), String.trimLeft(), String.trimRight() patch update

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Ioseb Dzmanashvili
<ioseb.dzmanashvili at gmail.com>'s request for review:
Bug 26590: Support for String.trim(), String.trimLeft() and String.trimRight()
methods
https://bugs.webkit.org/show_bug.cgi?id=26590

Attachment 31774: String.trim(), String.trimLeft(), String.trimRight() patch
update
https://bugs.webkit.org/attachment.cgi?id=31774&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
r- per the above (unresolved) isWhiteSpace discussion.

My question would be why should isStrWhiteSpace not respect 0x200b?  If it
should then we should just change isStrWhiteSpace.  If it shouldn't, then you
should add your own function:

static inline bool isTrimableWhiteSpaceChar(int c)
{
    return isStrWhiteSpace(c) || c == 0x200b; // zero width space
}

or similar.