[webkit-reviews] review requested: [Bug 23849] Keyboard shortcuts needed in Web Inspector : [Attachment 32044] Previous patch with Timothy's comments addressed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 30 02:23:05 PDT 2009


Yury Semikhatsky <yurys at chromium.org> has asked Timothy Hatcher
<timothy at hatcher.name> for review:
Bug 23849: Keyboard shortcuts needed in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=23849

Attachment 32044: Previous patch with Timothy's comments addressed.
https://bugs.webkit.org/attachment.cgi?id=32044&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
I've  fixed all of the pointed issues(sorry, it's hard to switch between two
different style guides) except for the semicolons. If you don't mind I'd rather
have each expression ending with semicolon explicitly to avoid possible nasty
errors happening when semicolon is accidentally omitted between two expressions
like in the following example: 

var x = {
  'i': 1,
  'j': 2
} 
// 2.  Trying to do one thing on IE and another on FF.
// I know you'd never write code like this, but throw me a bone.
[normalVersion, ffVersion][isIE]();


More information about the webkit-reviews mailing list