[webkit-reviews] review denied: [Bug 26776] Write more XSSAuditor tests : [Attachment 31981] More test cases

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 26776: Write more XSSAuditor tests
https://bugs.webkit.org/show_bug.cgi?id=26776

Attachment 31981: More test cases
https://bugs.webkit.org/attachment.cgi?id=31981&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Yay!  Tests === the awesome.

> +function getXMLHTTPRequest() {

> +function sendRequest(url, params, HTTPMethod) {

What's the point of these functions?  They don't seem to be used...

> +function sendRequestFromIFrame(url, params, HTTPMethod) {
> +	if (!params || params.length == 0) {
> +		return;
> +	}

Please convert all the tabs to spaces.	(Four space indent.)

> +	var iFrameObj = document.createElement('iframe');
> +	with(iFrameObj) {
> +		id = "_ffiFrame";
> +		height = "1";
> +		width = "1";
> +		style.visibility = "hidden";
> +	}

Yuck.  Please don't use |width|.  Just assign the properties of iFrameObj. 
(Also, you can use an simpler name, like frame.)